[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: simpler srfi 45 implementation
Sorry, I hit 'Reply' instead of 'Reply to all'.
On Nov 13, 2007 9:59 AM, Phil Bewig <pbewig@xxxxxxxxx
I did perform the SRFI-45 tests, and I think I did them on this version of the code, but I will confess I've been through enough versions of this recently that I'm not entirely sure I tested all of them.
I think at the moment I'll regress to the original SRFI-45 code for SRFI-41. If we all agree on a better version later I can always make the change.
On Nov 13, 2007 9:54 AM, AndrevanTonder <andre@xxxxxxxxxxxxx
On Tue, 13 Nov 2007, Eli Barzilay wrote:The suggested optimization looks very suspicious also to me.
> I was aware of the possible optimization at the time, but didn't find
> any example where it mattered. However, if you do put it in:
>> [(promise? p)
>> (let* ((v (force p)))
>> (if (not (pair? (promise-p prom)))
>> (set-promise-p! prom (list v)))
>> (car (promise-p prom)))]
> then you do the recursive forcing of `p' in a non-tail conext. My
> (vague, not formal at all) feeling about these "referral promises" is
> that they do happen in places where the original code had a tail call,
> so it might be a bad idea to break it.
It seems that the non-tail-call could break space-safety.
- Have you run the SRFI-45 tests on your suggested optimization?
Note that this involves uncommenting the mostly nonterminating
test cases, letting them run for some time, keeping track
of the memory consumption with some other tool, and verifying
that it stays bounded. Of course, this is not a substitute
for a theoretical analysis, but it should show pretty quickly
if you are not on the right track.
- Did you find the same slowdown for the first implementation
given in the message
(That one is easier for me to understand and comment on - Eli's
I would have to study again).