[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

*To*: Jamison Hope <jrh@xxxxxxxxxxxxxxx>*Subject*: Re: two bugs in reference implementation of SRFI 13*From*: Taylor R Campbell <campbell+srfi@xxxxxxxxxx>*Date*: Sat, 24 Dec 2011 20:40:50 +0000*Cc*: srfi-13@xxxxxxxxxxxxxxxxx*Delivered-to*: srfi-13@xxxxxxxxxxxxxxxxx*In-reply-to*: <y9lsjk94upx.fsf@xxxxxxxxxxxxxxx> (jrh@xxxxxxxxxxxxxxx)*Sender*: Taylor R Campbell <campbell@xxxxxxxxxx>*User-agent*: IMAIL/1.21; Edwin/3.116; MIT-Scheme/9.1

Date: Sat, 24 Dec 2011 20:48:10 +0100 From: Jamison Hope <jrh@xxxxxxxxxxxxxxx> string-parse-start+end is documented to return three values: "rest start end", but in make-kmp-restart-vector its result is bound to two variables (start end). I found the same issue in string-kmp-partial-search, which also attempts to capture only the "start" and "end" values. The fix in both places is to call string-parse-final-start+end instead, which strips off the first unwanted rest value from string-parse-start +end. Not quite. The fix is to identify and use the intended definition of the name LET-OPTIONALS*. With Olin's definition of LET-OPTIONALS*, such as you will find in scsh, or reimplemented with SYNTAX-RULES in more recent Scheme48, the use of STRING-PARSE-START+END is correct. It seems (a) he forgot to say what definition to use in the reference implementation, and (b) the authors of Kawa chose a different one.

**Follow-Ups**:**Re: two bugs in reference implementation of SRFI 13***From:*Jamison Hope

**References**:**two bugs in reference implementation of SRFI 13***From:*Jamison Hope

- Prev by Date:
**two bugs in reference implementation of SRFI 13** - Next by Date:
**Re: two bugs in reference implementation of SRFI 13** - Previous by thread:
**two bugs in reference implementation of SRFI 13** - Next by thread:
**Re: two bugs in reference implementation of SRFI 13** - Index(es):